Skip to content

Extend functionality of LinearBurkeRate#1801

Merged
ischoegl merged 8 commits intoCantera:mainfrom
speth:burke-python
Nov 2, 2024
Merged

Extend functionality of LinearBurkeRate#1801
ischoegl merged 8 commits intoCantera:mainfrom
speth:burke-python

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Oct 25, 2024 •
edited
Loading

This wraps up a few loose ends from the main PR implementing the Burke linear mixing rule rate (#1710).

Changes proposed in this pull request

  • Fix round-trip YAML serialization
  • Enable creation in Python from dict input
  • Add standard set of Python reaction rate tests

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the Kinetics label Oct 25, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.41975% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (3ba21c4) to head (1ed79de).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/kinetics/LinearBurkeRate.cpp 89.18% 0 Missing and 8 partials ⚠️
interfaces/cython/cantera/reaction.pyx 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1801      +/-   ##
==========================================
+ Coverage   73.09%   73.26%   +0.16%     
==========================================
  Files         383      383              
  Lines       54617    54620       +3     
  Branches     9101     9099       -2     
==========================================
+ Hits        39921    40016      +95     
+ Misses      11698    11601      -97     
- Partials     2998     3003       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speth speth force-pushed the burke-python branch 2 times, most recently from dc03727 to 11d7400 Compare October 31, 2024 15:12
@speth speth marked this pull request as ready for review November 1, 2024 16:56
ischoegl
ischoegl approved these changes Nov 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth! This all looks good to me.

@ischoegl ischoegl merged commit 066120c into Cantera:main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ischoegl ischoegl ischoegl approved these changes

Assignees

No one assigned

Labels

Kinetics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@speth @ischoegl