Restore compatibility with expected minimum Cython version#1798
Merged
ischoegl merged 2 commits intoCantera:mainfrom Oct 21, 2024
Merged
Restore compatibility with expected minimum Cython version#1798ischoegl merged 2 commits intoCantera:mainfrom
ischoegl merged 2 commits intoCantera:mainfrom
Conversation
speth
force-pushed
the
cython-backwards-compat
branch
from
8db52bc to
d49b4c8
Compare
speth
force-pushed
the
cython-backwards-compat
branch
from
d49b4c8 to
6320dd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
- Coverage 73.24% 73.23% -0.01%
==========================================
Files 381 381
Lines 54377 54390 +13
Branches 9066 9066
==========================================
+ Hits 39826 39833 +7
- Misses 11580 11585 +5
- Partials 2971 2972 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The stated minimum version of Cython is 0.29.31, in both the documentation of the dependencies and as checked by SCons. However, Cantera currently fails to compile except with Cython 3.0.0 and newer due to differences in the way
__add__/__radd__and related operators are implemented.While I expect we'll probably drop support for anything older than Cython 3.0.0 after the Cantera 3.1 release, I'd like to maintain support for these older versions for the time being.
This also updates the CI configuration to make sure we're testing more than just the latest and greatest Cython version.
Checklist
scons build&scons test) and unit tests address code coverage