Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1792 +/- ##
=======================================
Coverage 73.23% 73.24%
=======================================
Files 381 381
Lines 54375 54375
Branches 9251 9254 +3
=======================================
+ Hits 39823 39826 +3
+ Misses 11580 11578 -2
+ Partials 2972 2971 -1 ☔ View full report in Codecov by Sentry. |
c95845a to
1cb392f
Compare
speth
left a comment
There was a problem hiding this comment.
This looks good to me, pending the fix for the failing tests.
1cb392f to
a8f761f
Compare
|
@speth … test is fixed but we appear to have a new upstream regression |
Changes proposed in this pull request
This PR separates
ReactorNetvisualization tweaks from #1788 to facilitate further reviews.diagram.viewThere is a caveat here, - see Cantera/enhancements#212, - as well as per @speth's comment:
On the other hand, there is @Naikless's original intent:
This PR attempts to stick with the original intent.
If applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#212 (minor aspect of this PR)
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage