Fix SCons option documentation#1790
Merged
ischoegl merged 3 commits intoCantera:mainfrom Sep 15, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1790 +/- ##
=======================================
Coverage 73.23% 73.24%
=======================================
Files 381 381
Lines 54375 54375
Branches 9251 9251
=======================================
+ Hits 39823 39826 +3
+ Misses 11580 11578 -2
+ Partials 2972 2971 -1 ☔ View full report in Codecov by Sentry. |
Buffering variables before configuration options are adjusted to the build system ensures that all SCons options are properly documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Ensure that all SCons options are listed (instead of documenting the configuration of the build system)
If applicable, fill in the issue number this pull request is fixing
Closes #1767
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage