Merged
Conversation
ischoegl
force-pushed
the
clib-housekeeping
branch
from
ad1ceeb to
fbeb5be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1780 +/- ##
=======================================
Coverage 73.20% 73.20%
=======================================
Files 381 381
Lines 54244 54240 -4
Branches 9237 9236 -1
=======================================
- Hits 39709 39707 -2
Misses 11564 11564
+ Partials 2971 2969 -2 ☔ View full report in Codecov by Sentry. |
ischoegl
force-pushed
the
clib-housekeeping
branch
from
fbeb5be to
cf1a57d
Compare
Replaced by SharedCabinet::at
Replaced by SharedCabinet::as
Revert to original name after SharedCabinet was introduced in Cantera#1448 and the original Cabinet was subsequently removed.
ischoegl
force-pushed
the
clib-housekeeping
branch
from
cf1a57d to
08c9ee6
Compare
Member
Author
speth
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR is mostly house-keeping for a simple bulk-replacement to streamline CLib's storage class (a left-over item from #1770 which I decided to break down into more manageable chunks)
SharedCabinet::itembySharedCabinet::atSharedCabinet::getby SharedCabinet::as`SharedCabinet::itemandSharedCabinet::getSharedCabinetback toCabinet(original name of before shared pointers were introduced in Smart clib cabinets / add Solution to clib API #1448)Checklist
scons build&scons test) and unit tests address code coverage