Skip to content

Make clib more consistent#1770

Closed
ischoegl wants to merge 21 commits intoCantera:mainfrom
ischoegl:update-clib-types
Closed

Make clib more consistent#1770
ischoegl wants to merge 21 commits intoCantera:mainfrom
ischoegl:update-clib-types

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Aug 11, 2024

Changes proposed in this pull request

🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧

  • Eliminate size_t from CLib API
  • Use const double* consistently for all setters
  • Eliminate SharedCabinet::item and SharedCabinet::get
  • Eliminate magic numbers from thermo_equilibrate
  • Eliminate various legacy constructors

Currently missing: ensure safe casting of size_t to int, ...

🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧

If applicable, fill in the issue number this pull request is fixing

Closes #1450
Partially addresses Cantera/enhancements#199 (.NET side)

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl added the clib label Aug 11, 2024
@ischoegl ischoegl force-pushed the update-clib-types branch 7 times, most recently from 4c8d520 to 92e9a28 Compare August 11, 2024 18:12
@ischoegl ischoegl force-pushed the update-clib-types branch 14 times, most recently from 3da80fa to cad4dc8 Compare August 12, 2024 22:48
@ischoegl ischoegl force-pushed the update-clib-types branch 2 times, most recently from 1284698 to 88c91a1 Compare August 13, 2024 00:14
@ischoegl ischoegl force-pushed the update-clib-types branch 2 times, most recently from ab7b8ba to b4b41a9 Compare August 13, 2024 01:48
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Aug 14, 2024

Mostly superseded by #1773. Edit: also #1780

@ischoegl ischoegl closed this Aug 14, 2024
@ischoegl ischoegl mentioned this pull request Aug 18, 2024
5 tasks
@ischoegl ischoegl deleted the update-clib-types branch August 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sourcegen fails to process clib signature

1 participant