Remove magic number support for Func1 in clib#1741
Conversation
3f1224c to
9e26507
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 73.04% 73.13% +0.09%
==========================================
Files 381 381
Lines 54164 54134 -30
Branches 9240 9222 -18
==========================================
+ Hits 39562 39590 +28
+ Misses 11633 11587 -46
+ Partials 2969 2957 -12 ☔ View full report in Codecov by Sentry. |
febb5aa to
9233036
Compare
0ee0ed4 to
998519b
Compare
b104e37 to
368b263
Compare
|
Ok. I think this is finally ready for a review. |
bryanwweber
left a comment
There was a problem hiding this comment.
Thanks @ischoegl! I don't know enough to say whether this is good, so I just had 2 small comments.
1bf5912 to
1ee2d1b
Compare
f0bc0e3 to
184f5a0
Compare
184f5a0 to
dcabfc5
Compare
|
@speth ... thanks for the review: I addressed all points. Beyond, I realized that there were still some unnecessary raw pointers left in the |
aa11184 to
c9e6213
Compare
Introduce transitional func_write3, as old API was non-functional.
Also, remove trivial helper functions for functor creation (gaussian, polynom, fplus, ftimes and frdivide)
Remove func_new and skip deprecation as it was only used by the legacy MATLAB toolbox.
Ensure that implementation matches docstring; now uses same order as MATLAB or NumPy. Use transitional name to prevent unintended behavior in user code.
Skip deprecation cycle for changed func_write as old API was broken.
Skip deprecation cycle as transitional name was only relevant for legacy MATLAB toolbox.
Func1 is consistent with nomenclature used in C++ and Python API's.
c9e6213 to
4e761a7
Compare
Changes proposed in this pull request
Func1via magic number fromclib(no longer needed after removal of legacy MATLAB toolbox in Remove legacy MATLAB toolbox #1670)Poly1(implementation did not match docstring; now, order matches NumPy and MATLAB); use transitional namesPoly13andpolynomial3to make changes tractablefunc_writeinclibcheckFunc1to check for existence of functorsFunc1codeExperimental MATLAB toolbox:
Func1code baseFunctoFunc1in order to be consistent with C++ and Python API'sPython API:
Func1.cxx_functorIf applicable, fill in the issue number this pull request is fixing
Closes #567
Examples
In the experimental MATLAB toolbox:
In Python:
Checklist
scons build&scons test) and unit tests address code coverage