Skip to content

Resolve compilation issues with C++20 mode and fmt 11.0#1739

Merged
speth merged 4 commits intoCantera:mainfrom
speth:cxx20-fmt
Jul 25, 2024
Merged

Resolve compilation issues with C++20 mode and fmt 11.0#1739
speth merged 4 commits intoCantera:mainfrom
speth:cxx20-fmt

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Jul 25, 2024 •
edited
Loading

Changes proposed in this pull request

  • Fix usage of fmt when compiling in C++20 mode
  • Add support for the recently-released fmt 11.0
  • Add CI tests specifying use of C++20 mode and using fmt 11.0

If applicable, fill in the issue number this pull request is fixing

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base (6931eb3) to head (03177f5).
Report is 1 commits behind head on main.

Files Patch % Lines
src/base/SolutionArray.cpp 96.15% 1 Missing ⚠️
src/thermo/PureFluidPhase.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1739   +/-   ##
=======================================
  Coverage   73.03%   73.03%           
=======================================
  Files         381      381           
  Lines       54128    54132    +4     
  Branches     9233     9233           
=======================================
+ Hits        39530    39534    +4     
  Misses      11635    11635           
  Partials     2963     2963

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ischoegl
ischoegl approved these changes Jul 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 … thanks, @speth - this all looks good to me!

@speth speth marked this pull request as ready for review July 25, 2024 12:56
@speth speth merged commit 9210b08 into Cantera:main Jul 25, 2024
@speth speth deleted the cxx20-fmt branch July 25, 2024 12:56
@bryanwweber bryanwweber mentioned this pull request Jul 29, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ischoegl ischoegl ischoegl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build fails with fmt 11.0.1 C++ API: compilation error with C++20 or newer

2 participants

@speth @ischoegl