Add electrochemical reactions to Science section#1737
Merged
speth merged 4 commits intoCantera:mainfrom Jul 25, 2024
Merged
Conversation
Solves cantera-website issue Cantera#172
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 73.02% 73.03%
=======================================
Files 381 381
Lines 54129 54128 -1
Branches 9236 9233 -3
=======================================
Hits 39530 39530
Misses 11635 11635
+ Partials 2964 2963 -1 ☔ View full report in Codecov by Sentry. |
speth
approved these changes
Jul 25, 2024
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me. I just pushed a minor change to fix one typo and a couple of nitpicky whitespace things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Adds description of Cantera's implementation of electrochemical rate theory to the
Referencesection of the website.Added to
doc/sphinx/reference/kinetics/reaction-rates.md.Closes Cantera/cantera-website#172
Gives a basic overview of how electrochemical reactions are handled in Cantera, including the concepts of:
Documentation also includes description of specifying the rate parameter as an "exchange current density."
Checklist
scons build&scons test) and unit tests address code coverage