Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1724 +/- ##
==========================================
- Coverage 72.80% 72.79% -0.01%
==========================================
Files 381 381
Lines 54011 54011
Branches 9207 9207
==========================================
- Hits 39321 39319 -2
- Misses 11706 11707 +1
- Partials 2984 2985 +1 ☔ View full report in Codecov by Sentry. |
bryanwweber
reviewed
Jun 24, 2024
Member
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Just a couple of small suggestions 😄
The javascript for the search box wouldn't work due to an earlier error in the javascript for the version switcher when the switcher JSON file couldn't be loaded.
- Structure comments for Sphinx Gallery - Show reactor network structure at start and end of simulation - Use pandas to show table of intermediate states and write CSV file
- Modify formatting for Sphinx Gallery - Use a larger mechanism file from the example_data repo to better demonstrate the benefits of preconditioning
Member
|
@speth will you fix the examples in this PR? I'm not sure if the failures are related to this branch. If not, I'll approve 😄 |
bryanwweber
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ReactorNetdrawing (introduced in Reactor net visualization #1624) to a couple of examplesMixtureclass and the multiphase equilibrium solversIf applicable, fill in the issue number this pull request is fixing
Closes Cantera/cantera-website#103
Checklist
scons build&scons test) and unit tests address code coverage