Skip to content

Update ReactorNet drawing functions#1714

Merged
ischoegl merged 3 commits intoCantera:mainfrom
speth:update-draw-rnet
Jun 21, 2024
Merged

Update ReactorNet drawing functions#1714
ischoegl merged 3 commits intoCantera:mainfrom
speth:update-draw-rnet

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Jun 18, 2024 •
edited
Loading

Changes proposed in this pull request

  • Avoid maintaining redundant docstrings in drawnetwork.py -- just reference the docs for the member function versions
  • Fix ability to pass arguments to ReactorNet.draw to show composition for all reactors in the network
  • When drawing the state, put the reactor label inside the reactor boundary to avoid ugly overlaps

If applicable, provide an example illustrating new features this pull request is introducing
Graph generated by adding

mixer.draw(print_state=True, species="X")

to mix1.py:

rnet

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth force-pushed the update-draw-rnet branch from d85265f to 87218b5 Compare June 19, 2024 23:30
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.82%. Comparing base (f4a88d2) to head (87218b5).

Files Patch % Lines
interfaces/cython/cantera/drawnetwork.py 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
- Coverage   72.83%   72.82%   -0.01%     
==========================================
  Files         379      379              
  Lines       53593    53595       +2     
  Branches     9122     9123       +1     
==========================================
+ Hits        39032    39033       +1     
- Misses      11609    11610       +1     
  Partials     2952     2952

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speth speth marked this pull request as ready for review June 20, 2024 12:54
bryanwweber
bryanwweber approved these changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @speth!

@ischoegl ischoegl merged commit e092189 into Cantera:main Jun 21, 2024
@speth speth deleted the update-draw-rnet branch June 21, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryanwweber bryanwweber bryanwweber approved these changes

Assignees

No one assigned

Labels

Python Reactors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@speth @bryanwweber @ischoegl