Simplify input for extensible interface reactions#1709
Merged
speth merged 2 commits intoCantera:mainfrom Jun 12, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
- Coverage 75.72% 75.72% -0.01%
==========================================
Files 443 443
Lines 60981 60982 +1
Branches 9557 9558 +1
==========================================
Hits 46178 46178
Misses 11777 11777
- Partials 3026 3027 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
rate-constantfield and needing theinterface-prefix on the implementation of the rate parameterization for extensible reactions on interfaces.If applicable, fill in the issue number this pull request is fixing
Closes #1620
Checklist
scons build&scons test) and unit tests address code coverage