Conversation
ischoegl
force-pushed
the
remove-legacy-matlab
branch
from
c4c2243 to
ba5b9f7
Compare
ischoegl
force-pushed
the
remove-legacy-matlab
branch
2 times, most recently
from
81cf9ee to
79becb6
Compare
|
This is ready for a review. |
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
This looks good to me, with just a couple of minor changes.
| (sec-install-macos)= | ||
| # macOS Matlab Toolbox | ||
|
|
||
| The Cantera Matlab toolbox can be installed using a macOS-specific installer. The | ||
| toolbox requires macOS version 10.15 (Catalina) or higher and a copy of Matlab built for | ||
| Intel processors (which will run under Rosetta 2 on ARM-based processors). |
There was a problem hiding this comment.
Should this redirect users to the 3.0 package, as you've done for the conda and Windows installer pages?
There was a problem hiding this comment.
As the macOS install instructions are specific to the legacy MATLAB toolbox which this PR removes, it in effect eliminates the need for the installer (which would be one less item to maintain) - from that perspective, the macOS installation instructions are moot? (the only instance ofsec-install-macos I found was in connection with MATLAB).
I did, on the other hand, add an admonition on the main install page that the legacy Matlab toolbox was removed, which would be my preferred resolution. Please let me know in case there's another use of the macOS installer that I am unaware of.
There was a problem hiding this comment.
Yes, the macOS package was only for the Matlab toolbox. From the standpoint of a Mac user wanting to install the Matlab toolbox, though, they need to see the directions to use the 3.0 toolbox somewhere. I think putting that information on the installation index page satisfies that scenario.
ischoegl
force-pushed
the
remove-legacy-matlab
branch
from
79becb6 to
111e5e4
Compare
|
@speth … thanks for the review. The main remaining question is about the fate of the macOS installer. Based on my understanding it’s no longer needed, and I added one more admonition to clarify. PS: found a typo and had to force-push, but it should all be taken care of now |
ischoegl
force-pushed
the
remove-legacy-matlab
branch
from
111e5e4 to
d740f1b
Compare
After the removal of the legacy MATLAB toolbox in Cantera#1670, all remaining interfaces that use clib are either experimental (matlab_experimental) or rudimentary/incomplete (Fortran, .NET). The change allows for a faster development cycle to fix accumulated issues and inconsistencies until stable APIs have been implemented.
After the removal of the legacy MATLAB toolbox in Cantera#1670, all remaining interfaces that use clib are either experimental (matlab_experimental) or rudimentary/incomplete (Fortran, .NET). The change allows for a faster development cycle to fix accumulated issues and inconsistencies until stable APIs have been implemented.
After the removal of the legacy MATLAB toolbox in Cantera#1670, all remaining interfaces that use clib are either experimental (matlab_experimental) or rudimentary/incomplete (Fortran, .NET). The change allows for a faster development cycle to fix accumulated issues and inconsistencies until stable APIs have been implemented.
After the removal of the legacy MATLAB toolbox in #1670, all remaining interfaces that use clib are either experimental (matlab_experimental) or rudimentary/incomplete (Fortran, .NET). The change allows for a faster development cycle to fix accumulated issues and inconsistencies until stable APIs have been implemented.
After the removal of the legacy MATLAB toolbox in Cantera#1670, all remaining interfaces that use clib are either experimental (matlab_experimental) or rudimentary/incomplete (Fortran, .NET). The change allows for a faster development cycle to fix accumulated issues and inconsistencies until stable APIs have been implemented.
2 participants
Changes proposed in this pull request
This PR seeks to map out the removal of the legacy MATLAB toolbox
interfaces/matlabItems to be deferred:
clibfunctions that were only used by legacy MATLAB toolboxIf applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#196
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage