Minor adjustment to debugging output in Sim1d.cpp for log levels >7#1660
Merged
speth merged 2 commits intoCantera:mainfrom Jan 18, 2024
Merged
Minor adjustment to debugging output in Sim1d.cpp for log levels >7#1660speth merged 2 commits intoCantera:mainfrom
speth merged 2 commits intoCantera:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1660 +/- ##
=======================================
Coverage 72.75% 72.76%
=======================================
Files 375 375
Lines 56584 56584
Branches 20494 20494
=======================================
+ Hits 41168 41171 +3
+ Misses 12401 12399 -2
+ Partials 3015 3014 -1 ☔ View full report in Codecov by Sentry. |
speth
requested changes
Jan 18, 2024
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks, @wandadars, the changes here makes sense to me. Besides one minor formatting quibble, I'd like to suggest rewriting the commit message to something along the lines of:
[1D] Set overwrite flag when saving debug output files
This prevents errors that could occur if the steady-state Newton solver
experiences failures after previous successful Newton solves. In this situation,
the data group at the highest level already exists in the debug file, and must
explicitly be overwritten.
This prevents errors that could occur if the steady-state Newton solver experiences failures after previous successful Newton solves. In this situation, the data group at the highest level already exists in the debug file, and must explicitly be overwritten.
…ng output files This is just to help contrast with the other entries in the file that are labelled as residual. A solution/residual naming scheme makes sense versus the current debug/residual naming scheme because both outputs are technically debugging information.
wandadars
force-pushed
the
debugging_sim1d_changes
branch
from
b073545 to
6604a7e
Compare
ischoegl
approved these changes
Jan 18, 2024
speth
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
I added the "true" overwrite flag to the debugging save() and saveResidual() calls in the Sim1d.cpp file to prevent code-stopping errors. I cam across this when trying to debug my work in #1622 . @ischoegl suggested putting the changes in a separate pull request.
To reproduce the error, run a 1D flow case that experiences failures in the steady newton solve, after taking a few successful newton solves. The error consists of the data group at the highest level already existing in the debug file, causing the code to error out.
Checklist
scons build&scons test) and unit tests address code coverage