ck2yaml argparse / yaml2k fixes#1616
Merged
ischoegl merged 9 commits intoCantera:mainfrom Sep 9, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
+ Coverage 72.66% 72.70% +0.03%
==========================================
Files 370 370
Lines 56255 56257 +2
Branches 20353 20351 -2
==========================================
+ Hits 40880 40903 +23
+ Misses 12372 12357 -15
+ Partials 3003 2997 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adopt the same naming convention as used by other converter scripts.
Also, add quiet option to suppress output
27af5b9 to
870b5b9
Compare
21fb071 to
17a211b
Compare
Member
Author
bryanwweber
reviewed
Sep 8, 2023
Member
bryanwweber
left a comment
There was a problem hiding this comment.
Tiny changes, thanks for taking this on!
252586d to
78b187e
Compare
Member
Author
|
@bryanwweber ... thank you for the suggestions! |
bryanwweber
approved these changes
Sep 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ck2yamltoargparsein order to be consistent with other converter scriptssphinx-argparseSolution.write_chemkinbugsIf applicable, fill in the issue number this pull request is fixing
Closes #1611, partially addresses #1610
If applicable, provide an example illustrating new features this pull request is introducing
ck2yamlnow has the following help text (generated byargparse)While not the main issue, this now works:
Checklist
scons build&scons test) and unit tests address code coverage