Skip to content

Add Python 3.12 post-merge-test#1612

Merged
speth merged 4 commits intoCantera:mainfrom
ischoegl:fix-strings
Sep 5, 2023
Merged

Add Python 3.12 post-merge-test#1612
speth merged 4 commits intoCantera:mainfrom
ischoegl:fix-strings

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Sep 2, 2023

Changes proposed in this pull request

This is a minor update to #1604.

At this point, fedora rawhide is still the only runner that uses Python 3.12 successfully.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the fix-strings branch 5 times, most recently from de18e58 to 0ab75c8 Compare September 2, 2023 23:30
@ischoegl ischoegl marked this pull request as ready for review September 2, 2023 23:33
@ischoegl ischoegl requested a review from a team September 2, 2023 23:44
@ischoegl ischoegl marked this pull request as draft September 3, 2023 02:04
@ischoegl ischoegl marked this pull request as ready for review September 3, 2023 02:52
@ischoegl ischoegl added the CI label Sep 3, 2023
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. This makes sense to me. I had just a couple of minor suggestions.

@ischoegl ischoegl force-pushed the fix-strings branch 4 times, most recently from 916984c to 5aa3117 Compare September 4, 2023 21:31
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Sep 5, 2023

@speth - thank you for the suggestions. I believe everything is addressed.

Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl - this looks good to me.

@speth speth merged commit c1281c1 into Cantera:main Sep 5, 2023
@ischoegl ischoegl deleted the fix-strings branch August 19, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants