Skip to content

Container-based GH actions#1608

Merged
speth merged 3 commits intoCantera:mainfrom
ischoegl:add-tests
Aug 30, 2023
Merged

Container-based GH actions#1608
speth merged 3 commits intoCantera:mainfrom
ischoegl:add-tests

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Aug 27, 2023 •
edited
Loading

Changes proposed in this pull request

  • Add CI tests running on official ubuntu docker images
  • Currently added to main.yaml to facilitate review; should be moved to post-merge-tests.yaml before merging
  • Move mingw runner to post-merge-tests
  • Remove vestigial h5py references

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl added the CI label Aug 27, 2023
@ischoegl ischoegl force-pushed the add-tests branch 26 times, most recently from 298f30a to d457d35 Compare August 28, 2023 02:11
@ischoegl ischoegl mentioned this pull request Aug 28, 2023
Merged
5 tasks
@ischoegl ischoegl marked this pull request as ready for review August 28, 2023 03:16
@ischoegl ischoegl requested a review from a team August 28, 2023 03:16
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #1608 (675e90e) into main (e2c446c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   72.66%   72.65%   -0.02%     
==========================================
  Files         370      370              
  Lines       56259    56255       -4     
  Branches    20353    20353              
==========================================
- Hits        40882    40873       -9     
- Misses      12374    12379       +5     
  Partials     3003     3003
Files Changed Coverage Δ
interfaces/cython/cantera/_utils.pyx 91.92% <ø> (+0.51%) ⬆️
interfaces/cython/cantera/onedim.py 84.97% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Aug 28, 2023 •
edited
Loading

As mentioned on top, the new runner should be moved before merging. It is currently in main.yaml so the CI is actually triggered and output can be reviewed. Edit: now moved to final location.

@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Aug 28, 2023 •
edited
Loading

I moved the docker tests to post-merge-tests to expedite things. Fwiw, the output of the CI run can be reviewed in previously successful GH Action runs, i.e.:

speth
speth reviewed Aug 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new jobs look good to me. Thanks for cleaning up the bits about h5py that I missed in #1605. My only suggestion is to keep the MinGW runner where it is.

@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Aug 29, 2023

@speth ... thanks for the feedback! No problem with leaving mingw where it was. Other than that, I believe we have a decent template to be used for regression tests with other Linux flavors in the future.

@ischoegl ischoegl requested a review from speth August 29, 2023 23:35
@speth speth merged commit 9ee13eb into Cantera:main Aug 30, 2023
@ischoegl ischoegl deleted the add-tests branch August 30, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@speth speth speth approved these changes

Assignees

No one assigned

Labels

CI compiling enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ischoegl @speth