Implement removals indicated by deprecations in Cantera 3.0#1605
Merged
ischoegl merged 22 commits intoCantera:mainfrom Aug 27, 2023
Merged
Implement removals indicated by deprecations in Cantera 3.0#1605ischoegl merged 22 commits intoCantera:mainfrom
ischoegl merged 22 commits intoCantera:mainfrom
Conversation
speth
force-pushed
the
remove-deprecated
branch
2 times, most recently
from
7160e4a to
be631b0
Compare
speth
force-pushed
the
remove-deprecated
branch
2 times, most recently
from
a930ec6 to
f666ee9
Compare
PARTIAL: remove 2-arg kineticsSpeciesIndex
speth
force-pushed
the
remove-deprecated
branch
2 times, most recently
from
2a22901 to
866f192
Compare
This takes care of simple removals of deprecated methods/classes
speth
force-pushed
the
remove-deprecated
branch
from
866f192 to
07c2acd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
+ Coverage 70.59% 72.66% +2.07%
==========================================
Files 379 370 -9
Lines 59185 56259 -2926
Branches 21270 20353 -917
==========================================
- Hits 41781 40882 -899
+ Misses 14325 12374 -1951
+ Partials 3079 3003 -76
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Without this, the error message confusingly mentions being unable to find the now-removed 'ideal-gas' PDSS model.
speth
force-pushed
the
remove-deprecated
branch
from
07c2acd to
fcab50a
Compare
ischoegl
approved these changes
Aug 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
I tried to break up the "interesting" changes into separate commits. This might be easiest to review on a commit-by-commit basis, where the commits "Remove code deprecated in Cantera 3.0" and "Remove deprecated Python code" consist almost entirely of straight removals of deprecated code.
Checklist
scons build&scons test) and unit tests address code coverage