Fix segfault in deprecated newPhase factory function#1600
Merged
ischoegl merged 1 commit intoCantera:mainfrom Aug 22, 2023
Merged
Fix segfault in deprecated newPhase factory function#1600ischoegl merged 1 commit intoCantera:mainfrom
ischoegl merged 1 commit intoCantera:mainfrom
Conversation
The shared_ptr goes out of scope at the end of the function, deleting the held ThermoPhase right as it's returned. Erroneous behavior introduced in f3e840d (Cantera#1448).
Codecov Report
@@ Coverage Diff @@
## main #1600 +/- ##
=======================================
Coverage 70.59% 70.59%
=======================================
Files 379 379
Lines 59168 59185 +17
Branches 21257 21270 +13
=======================================
+ Hits 41768 41781 +13
- Misses 14324 14325 +1
- Partials 3076 3079 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shared_ptrgoes out of scope at the end of the function, deleting the heldThermoPhaseright as it's returned.Erroneous behavior introduced in f3e840d (#1448).
Changes proposed in this pull request
shared_ptr-based implementation with one that uses aunique_ptr(which can be released without destroying the underlying object)Checklist
scons build&scons test) and unit tests address code coverage