Make SolutionArray formatting consistent for different {fmt} versions#1547
Merged
ischoegl merged 4 commits intoCantera:mainfrom Jul 18, 2023
Merged
Make SolutionArray formatting consistent for different {fmt} versions#1547ischoegl merged 4 commits intoCantera:mainfrom
ischoegl merged 4 commits intoCantera:mainfrom
Conversation
Make it explicit that these should be printed as integers. Behavior of {fmt}
is different between 6.1.2, which always includes a decimal digit when the
input type is double if no other formatting specifier is provided, and later
versions which format integral doubles as doubles.
Fixes Cantera#1526
Codecov Report
@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
- Coverage 70.49% 70.46% -0.03%
==========================================
Files 379 379
Lines 59091 59091
Branches 21228 21228
==========================================
- Hits 41658 41641 -17
- Misses 14353 14369 +16
- Partials 3080 3081 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ischoegl
requested changes
Jul 18, 2023
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
Should we set up ubuntu-multiple-pythons runners to use system_fmt=y, so this is covered by CI?
This extends the tested versions to include fmt 6.1.2 on Ubuntu 20.04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
With {fmt} 6.1.2, this changes the output of:
from
to
If applicable, fill in the issue number this pull request is fixing
Closes #1526
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage