[SCons] Require minimum HighFive version#1529
Merged
speth merged 1 commit intoCantera:mainfrom Jul 5, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
+ Coverage 70.50% 70.51% +0.01%
==========================================
Files 376 376
Lines 59075 59075
Branches 21219 21219
==========================================
+ Hits 41649 41656 +7
+ Misses 14348 14341 -7
Partials 3078 3078 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
speth
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Require
HighFive>=2.5If applicable, fill in the issue number this pull request is fixing
Closes #1527
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage