Skip to content

Update C++ SolutionArray interface to use 'int'#1520

Merged
speth merged 4 commits intoCantera:mainfrom
ischoegl:fix-msvc-warnings
Jun 29, 2023
Merged

Update C++ SolutionArray interface to use 'int'#1520
speth merged 4 commits intoCantera:mainfrom
ischoegl:fix-msvc-warnings

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Jun 29, 2023 •
edited
Loading

Changes proposed in this pull request

  • Use int for all C++ SolutionArray interface methods
  • Fixes MSVC warnings
  • Avoids potential warnings from clib

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl
[base] Use 'int' for SolutionArray API
bc92fca 
Fixes MSVC compiler warnings
@ischoegl ischoegl mentioned this pull request Jun 29, 2023
Merged
5 tasks
@ischoegl ischoegl force-pushed the fix-msvc-warnings branch from 364a754 to c6b24c1 Compare June 29, 2023 16:34
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #1520 (c6b24c1) into main (25fee18) will increase coverage by 0.00%.
The diff coverage is 75.43%.

❗ Current head c6b24c1 differs from pull request most recent head bde12f2. Consider uploading reports for the commit bde12f2 to get more accurate results

@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files         376      376           
  Lines       58913    58918    +5     
  Branches    21198    21198           
=======================================
+ Hits        41546    41551    +5     
  Misses      14308    14308           
  Partials     3059     3059
Impacted Files Coverage Δ
src/clib/ctfunc.cpp 32.71% <20.00%> (+0.63%) ⬆️
src/clib/Cabinet.h 54.41% <66.66%> (-0.67%) ⬇️
src/base/SolutionArray.cpp 78.85% <87.80%> (+0.07%) ⬆️
include/cantera/base/SolutionArray.h 94.44% <100.00%> (ø)
src/oneD/StFlow.cpp 82.18% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ischoegl ischoegl requested review from a team and speth and removed request for speth June 29, 2023 21:32
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Jun 29, 2023

@speth ... I cherry-picked the yaml-cpp commit from #1519, so this can all be taken care of at the same time.

speth
speth approved these changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. These updates look fine to me.

@speth speth merged commit 03f5b82 into Cantera:main Jun 29, 2023
@ischoegl ischoegl deleted the fix-msvc-warnings branch June 29, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@speth speth speth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Cantera 3.0 Release Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ischoegl @speth