Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 70.46% 70.46% -0.01%
==========================================
Files 375 375
Lines 58405 58408 +3
Branches 20899 20901 +2
==========================================
Hits 41158 41158
- Misses 14227 14228 +1
- Partials 3020 3022 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
speth
force-pushed
the
cleanup-for-conda
branch
3 times, most recently
from
1066187 to
fce66b1
Compare
This speeds up some incremental builds when switching between configurations with and without the Python module, as done during Conda packaging.
This library is always loaded using the unversioned name.
speth
force-pushed
the
cleanup-for-conda
branch
3 times, most recently
from
9e7907f to
700624c
Compare
On Windows, the search path for DLLs is the "bin" dir. "lib" dirs are used only for static and "import" libraries.
Compiler flags were getting deleted because they start with '/' not '-'.
Previous cleanup of this was overly agressive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This is a companion to Cantera/conda-recipes#44 for updates that need to be made in the main Cantera repository.
Note: I've also pushed this branch to the
Cantera/canterarepository to allow me to run the Conda packaging CI against this branch. This will be deleted later.CT_HAS_PYTHONpreprocessor variable to enable more efficient incremental buildscantera_shared.dllto theLibrary\bindirectory, where all the other conda package DLLs goSConstruct/CMakeLists.txtfilesChecklist
scons build&scons test) and unit tests address code coverage