Break out thermo consistency tests#1501
Merged
ischoegl merged 5 commits intoCantera:mainfrom Jun 13, 2023
Merged
Conversation
speth
force-pushed
the
breakout-consistency
branch
from
afdce7f to
477f245
Compare
This improves the accuracy of derived properties calculated using finite differences.
speth
force-pushed
the
breakout-consistency
branch
2 times, most recently
from
a3a32c1 to
6280677
Compare
Codecov Report
@@ Coverage Diff @@
## main #1501 +/- ##
==========================================
+ Coverage 69.48% 69.77% +0.28%
==========================================
Files 377 377
Lines 58011 58011
Branches 20695 20695
==========================================
+ Hits 40311 40479 +168
+ Misses 14748 14577 -171
- Partials 2952 2955 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Failing test cases documented in Cantera#1500
speth
force-pushed
the
breakout-consistency
branch
from
6280677 to
b1fd213
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Checklist
scons build&scons test) and unit tests address code coverage