Polynomial Ea coverage dependency#1495
Merged
speth merged 4 commits intoCantera:mainfrom Jun 15, 2023
Merged
Conversation
jongyoonbae
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 70.25% 70.25%
=======================================
Files 375 375
Lines 58266 58292 +26
Branches 20807 20828 +21
=======================================
+ Hits 40935 40955 +20
- Misses 14348 14351 +3
- Partials 2983 2986 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
speth
requested changes
Jun 11, 2023
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks for this contribution, @jongyoonbae. I think it generally looks good, and I just had a couple of minor comments on the implementation.
speth
requested changes
Jun 13, 2023
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks for the updates, @jongyoonbae. I found just one spot where I think an update is needed.
speth
approved these changes
Jun 15, 2023
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks, @jongyoonbae! This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
InterfaceRateon top of the current linear coverage dependency.Eincoverage-dependenciesis given as a scalar value.Eis given as a list of four values, the 4th-order polynomial dependency is applied.InterfaceRate.cppandInterfaceRate.has well as additional documentations inInterfaceRate.handreactions.rstare appended.kineticsFromYaml.cppwith additional dummy coverage dependency parameters insurface-phases.yaml.If applicable, fill in the issue number this pull request is fixing
Closes #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage