[Equil] Handle factorization errors in initial estimator#1479
Merged
ischoegl merged 1 commit intoCantera:mainfrom Apr 17, 2023
Merged
[Equil] Handle factorization errors in initial estimator#1479ischoegl merged 1 commit intoCantera:mainfrom
ischoegl merged 1 commit intoCantera:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
- Coverage 70.05% 70.05% -0.01%
==========================================
Files 377 377
Lines 57788 57789 +1
Branches 19410 19410
==========================================
Hits 40482 40482
- Misses 14745 14747 +2
+ Partials 2561 2560 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ischoegl
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ChemEquil::estimateElementPotentialsIf applicable, fill in the issue number this pull request is fixing
Closes #1473
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage