Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1420 +/- ##
=======================================
Coverage 70.78% 70.78%
=======================================
Files 373 373
Lines 53872 53873 +1
Branches 17579 17579
=======================================
+ Hits 38131 38133 +2
+ Misses 13339 13338 -1
Partials 2402 2402
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ischoegl
requested review from
a team and
bryanwweber
and removed request for
bryanwweber
speth
previously approved these changes
Jan 3, 2023
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Looks good to me. My only request is for a descriptive commit message rather than just a reference to the GitHub issue.
Member
Author
👍 Thanks for the review - commit message is updated! |
Prior to this fix, third body efficiencies were erroneously specified for third body reactions with explicit collision partners (see Cantera#1415).
speth
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Skip third body efficiencies in CK output when third-body collider is explicitly specified
If applicable, fill in the issue number this pull request is fixing
Closes #1415
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage