Removed redundant error checks to fix issue #1412#1413
Merged
ischoegl merged 1 commit intoCantera:mainfrom Dec 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 71.16% 70.79% -0.38%
==========================================
Files 373 373
Lines 52276 53872 +1596
Branches 17374 17579 +205
==========================================
+ Hits 37204 38139 +935
- Misses 12718 13332 +614
- Partials 2354 2401 +47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ischoegl
approved these changes
Dec 10, 2022
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
Thanks! - The fix looks good to me.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
clib/ct.cppso external language interfaces can correctly handle errors returned by the methodthermo_setDensityandthermo_setMolarDensity.If applicable, fill in the issue number this pull request is fixing
Closes #1412
Checklist
scons build&scons test) and unit tests address code coverage