changes default preconditioner threshold to zero#1344
Merged
ischoegl merged 1 commit intoCantera:mainfrom Jul 30, 2022
Merged
Conversation
ischoegl
reviewed
Jul 29, 2022
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
It may be good to put the rationale for the change in the commit message so what's written in the PR is preserved.
@anthony-walker's study showed that using no threshold often leads to as good—and sometimes better—performance than an arbitrary threshold value, and setting a non-zero value should only be done intentionally by someone trying to tune for optimal performance.
kyleniemeyer
force-pushed
the
change-default-threshold
branch
from
4c767e1 to
163d469
Compare
Member
Author
|
@ischoegl good suggestion, done! |
ischoegl
approved these changes
Jul 30, 2022
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
Thanks, @kyleniemeyer! LGTM.
Codecov Report
@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
+ Coverage 68.03% 68.15% +0.11%
==========================================
Files 327 327
Lines 42652 42658 +6
Branches 17180 17180
==========================================
+ Hits 29020 29074 +54
+ Misses 11345 11291 -54
- Partials 2287 2293 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This pull request makes one small, simple change: the default threshold for using the adaptive preconditioner is now 0.0, rather than the (arbitrary) 1e-8.
@anthony-walker's study showed that using no threshold often leads to as good—and sometimes better—performance than an arbitrary threshold value, and setting a non-zero value should only be done intentionally by someone trying to tune for optimal performance.
Checklist
scons build&scons test) and unit tests address code coverage