Skip to content

[Units] Add Cython interface for some functions#1285

Merged
ischoegl merged 2 commits intoCantera:mainfrom
bryanwweber:add-units-helpers
May 30, 2022
Merged

[Units] Add Cython interface for some functions#1285
ischoegl merged 2 commits intoCantera:mainfrom
bryanwweber:add-units-helpers

Conversation

@bryanwweber
Copy link
Copy Markdown
Member

These functions are chosen for their potential utility. Setting units is
not enabled by this interface because it is meant to be handled
internally. However, these methods can help to determine the unit
factors for reaction rates.

Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dove-tails nicely with #1076. I have one minor suggestion ...

@bryanwweber bryanwweber force-pushed the add-units-helpers branch 2 times, most recently from 3284bc8 to fe2dd53 Compare May 26, 2022 14:54
These functions are chosen for their potential utility. Setting units is
not enabled by this interface because it is meant to be handled
internally. However, these methods can help to determine the unit
factors for reaction rates.
@bryanwweber bryanwweber requested a review from ischoegl May 29, 2022 16:32
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - LGTM!

@ischoegl ischoegl merged commit aef1843 into Cantera:main May 30, 2022
@bryanwweber bryanwweber deleted the add-units-helpers branch August 2, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants