Port lithium_ion_battery.m to Python#1263
Merged
speth merged 2 commits intoCantera:mainfrom Apr 30, 2022
Merged
Conversation
5 tasks
ischoegl
force-pushed
the
test-electron-density-formulation
branch
from
cfbddc8 to
5421e42
Compare
Member
|
Here's the MATLAB version of that graph -- looks good to me: |
ischoegl
force-pushed
the
test-electron-density-formulation
branch
from
5421e42 to
65fad04
Compare
Codecov Report
@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 65.56% 65.72% +0.15%
==========================================
Files 329 329
Lines 46668 46671 +3
Branches 19855 19855
==========================================
+ Hits 30598 30673 +75
+ Misses 13508 13428 -80
- Partials 2562 2570 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
Author
|
This is ready for review … @decaluwe please feel free to push suggestions directly to this branch. |
ischoegl
force-pushed
the
test-electron-density-formulation
branch
from
65fad04 to
69186cd
Compare
speth
previously approved these changes
Apr 30, 2022
interfaces/cython/cantera/examples/surface_chemistry/lithium_ion_battery.py
Outdated
Show resolved
Hide resolved
interfaces/cython/cantera/examples/surface_chemistry/lithium_ion_battery.py
Outdated
Show resolved
Hide resolved
interfaces/cython/cantera/examples/surface_chemistry/lithium_ion_battery.py
Outdated
Show resolved
Hide resolved
ischoegl
force-pushed
the
test-electron-density-formulation
branch
from
69186cd to
5667358
Compare
Member
Author
|
@speth ... thanks for the quick review! Re-approval is needed as I squashed the fixes ... |
speth
approved these changes
Apr 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Port
lithium_ion_battery.mto Python. Ultimately, this was the most efficient resolution.If applicable, fill in the issue number this pull request is fixing
Closes #1259
If applicable, provide an example illustrating new features this pull request is introducing
Results ... @decaluwe, please confirm that this is consistent, as I currently don't have a MATLAB version installed.
If the CTI input is used, the output is zero (see #1256). I will add a unit test once #1256 is merged.
Checklist
scons build&scons test) and unit tests address code coverage