Direct pip to build in place and not in /tmp#1261
Merged
bryanwweber merged 1 commit intoCantera:mainfrom Apr 29, 2022
Merged
Conversation
bryanwweber
approved these changes
Apr 29, 2022
Member
bryanwweber
left a comment
There was a problem hiding this comment.
Thanks @santoshshanbhogue, will merge once the tests pass 👍
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This will direct pip to build in place and not in a temporary directory. Future versions of pip will not be building in a temporary directory according to a depreciation warning:
DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default. pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.--use-feature=in-tree-buildto pip in theSConscriptfile for the python buildIf applicable, fill in the issue number this pull request is fixing
Closes #1260
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage