Skip to content

Direct pip to build in place and not in /tmp#1261

Merged
bryanwweber merged 1 commit intoCantera:mainfrom
santoshshanbhogue:tmpdir_2.6
Apr 29, 2022
Merged

Direct pip to build in place and not in /tmp#1261
bryanwweber merged 1 commit intoCantera:mainfrom
santoshshanbhogue:tmpdir_2.6

Conversation

@santoshshanbhogue
Copy link
Copy Markdown
Contributor

Changes proposed in this pull request
This will direct pip to build in place and not in a temporary directory. Future versions of pip will not be building in a temporary directory according to a depreciation warning:

DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default. pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.

  • Add the --use-feature=in-tree-build to pip in the SConscript file for the python build

If applicable, fill in the issue number this pull request is fixing

Closes #1260

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • [X ] Commit messages have short titles and reference relevant issues
  • [X ] Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link
Copy Markdown
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @santoshshanbhogue, will merge once the tests pass 👍

@bryanwweber bryanwweber merged commit b5f2194 into Cantera:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation on platforms with disk quotas in /tmp

2 participants