Enforce third-body concentration as argument to falloff_function#1257
Merged
ischoegl merged 2 commits intoCantera:mainfrom Apr 29, 2022
Merged
Enforce third-body concentration as argument to falloff_function#1257ischoegl merged 2 commits intoCantera:mainfrom
ischoegl merged 2 commits intoCantera:mainfrom
Conversation
ischoegl
changed the title
FalloffRate.falloff_function requires knowledge of both temperature and third-body concentration
bryanwweber
reviewed
Apr 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #1257 +/- ##
==========================================
+ Coverage 65.50% 65.52% +0.01%
==========================================
Files 329 329
Lines 46666 46666
Branches 19855 19855
==========================================
+ Hits 30568 30576 +8
+ Misses 13538 13530 -8
Partials 2560 2560
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bryanwweber
approved these changes
Apr 29, 2022
Member
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
LGTM, thanks @ischoegl! Will merge after the tests finish. Feel free to merge if I don't get to it first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The method is new in 2.6, and simply breaks out C++ code to the Python API.
If applicable, fill in the issue number this pull request is fixing
Closes #1254
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage