Skip to content

Minor tweaks for 2.6 beta#1212

Merged
speth merged 1 commit intoCantera:mainfrom
ischoegl:rename-mole-to-molar
Mar 13, 2022
Merged

Minor tweaks for 2.6 beta#1212
speth merged 1 commit intoCantera:mainfrom
ischoegl:rename-mole-to-molar

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Mar 8, 2022 •
edited
Loading

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

N/A

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team March 8, 2022 21:44
@ischoegl ischoegl marked this pull request as draft March 12, 2022 19:21
@ischoegl ischoegl force-pushed the rename-mole-to-molar branch from 0294369 to 67f5b44 Compare March 12, 2022 19:37
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Mar 12, 2022

@speth / @bryanwweber ... I removed the molar/mole changes.

@ischoegl ischoegl marked this pull request as ready for review March 12, 2022 19:39
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2022

Codecov Report

Merging #1212 (67f5b44) into main (8cdcef1) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    Cantera/cantera#1212      +/-   ##
==========================================
+ Coverage   65.38%   65.42%   +0.04%     
==========================================
  Files         318      320       +2     
  Lines       46095    46247     +152     
  Branches    19604    19655      +51     
==========================================
+ Hits        30139    30259     +120     
- Misses      13442    13460      +18     
- Partials     2514     2528      +14
Impacted Files Coverage Δ
include/cantera/kinetics/Kinetics.h 36.52% <ø> (ø)
include/cantera/kinetics/RateCoeffMgr.h 85.71% <0.00%> (-14.29%) ⬇️
include/cantera/kinetics/ReactionData.h 88.88% <0.00%> (-4.87%) ⬇️
src/kinetics/Kinetics.cpp 68.80% <0.00%> (-3.67%) ⬇️
src/kinetics/InterfaceKinetics.cpp 75.79% <0.00%> (-3.17%) ⬇️
src/kinetics/ReactionFactory.cpp 89.89% <0.00%> (-0.16%) ⬇️
include/cantera/kinetics/Reaction.h 100.00% <0.00%> (ø)
include/cantera/kinetics/InterfaceKinetics.h 85.71% <0.00%> (ø)
include/cantera/kinetics/InterfaceRate.h 84.14% <0.00%> (ø)
src/kinetics/InterfaceRate.cpp 91.81% <0.00%> (ø)
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

speth
speth approved these changes Mar 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@speth speth merged commit e6a5ffd into Cantera:main Mar 13, 2022
@ischoegl ischoegl deleted the rename-mole-to-molar branch March 13, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@speth speth speth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ischoegl @speth