Skip to content

GitHub runners for Windows 2022#1208

Merged
bryanwweber merged 5 commits intoCantera:mainfrom
ischoegl:windows-2022-runner
Mar 5, 2022
Merged

GitHub runners for Windows 2022#1208
bryanwweber merged 5 commits intoCantera:mainfrom
ischoegl:windows-2022-runner

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Feb 25, 2022 •
edited
Loading

Changes proposed in this pull request

  • Migrate GH environment from windows-2016 to windows-2022
  • Switch to conda driven compilation environment
  • Retain windows-2019 without changes
  • Add basic tests for scons install in conda-based runners

If applicable, fill in the issue number this pull request is fixing

Closes #1199

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Other

#1192 prevents some tests for conda-based installations on windows.

@ischoegl ischoegl force-pushed the windows-2022-runner branch 5 times, most recently from 3a8c8ce to 388bc4b Compare February 25, 2022 17:45
@ischoegl ischoegl added the CI label Feb 25, 2022
@ischoegl ischoegl force-pushed the windows-2022-runner branch 2 times, most recently from 3f613a5 to 5f37361 Compare February 25, 2022 18:10
bryanwweber
bryanwweber reviewed Feb 25, 2022
View reviewed changes
@ischoegl ischoegl force-pushed the windows-2022-runner branch 2 times, most recently from aa8a792 to dd11fa5 Compare February 25, 2022 18:42
@ischoegl ischoegl marked this pull request as ready for review February 25, 2022 19:36
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Feb 25, 2022 •
edited
Loading

🎉 ... this appears to work (at least for MSVC 14.3).

Regarding MSVC 14.0 (which compiles on my local machine for VS 2022), here is a relevant snippet from the complete build logs

scons: warning: VC version 14.0 not installed.  C/C++ compilers are most likely not set correctly.
 Installed versions are: ['14.3']
File "D:\a\cantera\cantera\SConstruct", line 753, in <module>

(see failed build log)

Fwiw, on a local windows installation with MSVC 14.0 through 14.3 installed, SCons detects

 Installed versions are: ['14.3', '14.0']

@ischoegl ischoegl requested a review from bryanwweber February 25, 2022 19:52
@ischoegl ischoegl force-pushed the windows-2022-runner branch 2 times, most recently from d6691a4 to 49c36d0 Compare February 25, 2022 22:07
bryanwweber
bryanwweber requested changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this as well! Disappointing that windows-2016 has to be dropped and we can't test MSVC 14.1, but oh well!

@ischoegl ischoegl force-pushed the windows-2022-runner branch 4 times, most recently from 76e61e2 to 96ad7c9 Compare March 3, 2022 21:35
@ischoegl ischoegl mentioned this pull request Mar 3, 2022
Closed
@ischoegl ischoegl force-pushed the windows-2022-runner branch 2 times, most recently from 59fda14 to 9797256 Compare March 4, 2022 15:09
@ischoegl ischoegl force-pushed the windows-2022-runner branch 2 times, most recently from 1798a22 to b92cdba Compare March 4, 2022 16:50
@ischoegl ischoegl force-pushed the windows-2022-runner branch 5 times, most recently from 7bf4194 to 0688afe Compare March 4, 2022 17:40
@ischoegl ischoegl force-pushed the windows-2022-runner branch from 0688afe to 8b28d83 Compare March 4, 2022 18:46
@ischoegl ischoegl requested a review from bryanwweber March 4, 2022 19:08
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Mar 4, 2022

@bryanwweber ... I think this is finally ready!

@ischoegl ischoegl mentioned this pull request Mar 5, 2022
Closed
@bryanwweber bryanwweber merged commit 8cdcef1 into Cantera:main Mar 5, 2022
@ischoegl ischoegl deleted the windows-2022-runner branch March 5, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryanwweber bryanwweber bryanwweber approved these changes

Assignees

No one assigned

Labels

CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace Windows 2016 GH Runner with Windows 2022 Jobs

2 participants

@ischoegl @bryanwweber