Merged
Conversation
Co-Authored-By: Bryan W. Weber <[email protected]>
Some PR's may create convergence issues in individual tests of the test suite that are only uncovered when a PR is pushed. This update ensures that jobs are cancelled to avoid CI bottlenecks.
ischoegl
force-pushed
the
simple-fixes
branch
from
625644f to
45076ac
Compare
bryanwweber
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Some simple fixes that address paper-cuts during compilation and CI runs.
For a successfully cancelled CI job (triggered by pushing another job 🎉), see Cantera/cantera/actions/runs/1862740301
If applicable, fill in the issue number this pull request is fixing
Closes #1188, closes #893
Checklist
scons build&scons test) and unit tests address code coverage