Implement serialization of Peng-Robinson phases#1180
Implement serialization of Peng-Robinson phases#1180bryanwweber merged 6 commits intoCantera:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 65.35% 65.40% +0.05%
==========================================
Files 315 318 +3
Lines 45999 46178 +179
Branches 19531 19639 +108
==========================================
+ Hits 30062 30203 +141
- Misses 13445 13470 +25
- Partials 2492 2505 +13
Continue to review full report at Codecov.
|
decaluwe
left a comment
There was a problem hiding this comment.
Thanks so much, @speth, both for the new capabilities and the significant cleanup of PengRobinson.
Everything looks good to me. I haven't downloaded and run installation to test, figuring that the test coverage would catch issues, but LMK if you'd like me to take that step.
No "real" changes below, only two comment lines that got moved that I think we'd probably be fine deleting.
The old values appear to have been copy-paste errors propagated from critProperties.xml.
18cdc8c to
0d4cef3
Compare
|
@decaluwe Is this good to merge? |
Changes proposed in this pull request
PengRobinsonclasscritical-properties.yamlIf applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage