Reduce precision in select tests to pass on alternate architectures#1178
Merged
speth merged 2 commits intoCantera:mainfrom Jan 19, 2022
mefuller:reduce_precision
Merged
Reduce precision in select tests to pass on alternate architectures#1178speth merged 2 commits intoCantera:mainfrom mefuller:reduce_precision
speth merged 2 commits intoCantera:mainfrom
mefuller:reduce_precision
Conversation
Contributor
Author
|
Alternate arch builds succeed for Fedora Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=81443230 |
speth
requested changes
Jan 19, 2022
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
These changes look reasonable to me, with one small fix.
speth
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Following on the discussion in #1174, minor changes in test tolerances are introduced to allow tests to pass on non-x86_64 architectures
EQwithNEARon several kinetics tests which were affecting all alternate architectures (https://copr.fedorainfracloud.org/coprs/fuller/Cantera/build/3192999/)If applicable, fill in the issue number this pull request is fixing
This closes #1174 as it corrects test/build failures with the following exceptions:
Test failures for s390x architecture and build failure on ppc64le (F36/Rawhide only) are identified there as originating outside of Cantera and will be addressed upstream.
Checklist
scons build&scons test) and unit tests address code coverage