Skip to content

Fix script installation path on Fedora 36#1172

Merged
ischoegl merged 1 commit intoCantera:mainfrom
speth:fedora-scriptpath
Jan 16, 2022
Merged

Fix script installation path on Fedora 36#1172
ischoegl merged 1 commit intoCantera:mainfrom
speth:fedora-scriptpath

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Jan 16, 2022

Changes proposed in this pull request

  • Make sure that scripts get installed to the same prefix as the Cantera Python module (e.g. /usr) instead of having the scripts installed under /usr/local on systems that use lib64 as the library directory name.

If applicable, fill in the issue number this pull request is fixing

Fixes #1149

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Python scripts like ck2yaml were being installed to /usr/local/bin instead
of /usr/bin.

Fixes Cantera#1149
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth! As the fix is confirmed in #1149, I believe this can be merged right away.

@ischoegl ischoegl merged commit 367d701 into Cantera:main Jan 16, 2022
@speth speth deleted the fedora-scriptpath branch July 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scons install places some files in wrong location on latest Fedora Linux

3 participants