Prevent inadvertent attribute assignment in Quantity#1124
Merged
ischoegl merged 1 commit intoCantera:mainfrom Oct 19, 2021
Merged
Prevent inadvertent attribute assignment in Quantity#1124ischoegl merged 1 commit intoCantera:mainfrom
ischoegl merged 1 commit intoCantera:mainfrom
Conversation
Add a '__slots__' definition to the Quantity class so trying to set the state using a property that doesn't exist for a particular phase model (e.g. HPQ) will not fail silently. Fixes Cantera#1093
ischoegl
reviewed
Oct 19, 2021
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
Looks good to me / verified that this works. But I haven't used this feature before myself, so it's probably a good idea if @bryanwweber would have a look also.
Member
|
I likewise haven't used these features but it also LGTM. |
ischoegl
approved these changes
Oct 19, 2021
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
I guess someone needs to approve ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
phase model (e.g.
HPQ) will not fail silentlyIf applicable, fill in the issue number this pull request is fixing
Fixes #1093
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage