Codecov Report

Merging #1122 (6798c57) into main (f46c3bb) will increase coverage by 0.00%.
The diff coverage is 67.14%.

❗ Current head 6798c57 differs from pull request most recent head cf97245. Consider uploading reports for the commit cf97245 to get more accurate results

@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         364      365    +1     
  Lines       47884    47912   +28     
=======================================
+ Hits        35172    35194   +22     
- Misses      12712    12718    +6     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46c3bb...cf97245. Read the comment docs.

as the latter is not available in older versions of libfmt

What's the oldest version that has fmt::appender? We could consider bumping the minimum version of libfmt.

What's the oldest version that has fmt::appender?

Hard to tell ... fmt::appender is implied to be preferable over std::back_inserter in fmtlib/fmt#2420, but it is also pointed out that it is undocumented (at least on their official documentation). It certainly isn't part of fmt v6.2.1 which is stock Ubuntu 18.04. There's also no information to be gleaned from the release notes.

Writing format_to(std::back_inserter(b), ...) every time gets a little clunky. I wouldn't be opposed adding a simple utility function like

template <typename... Args>
void fmt_append(fmt::memory_buffer& b, Args... args) {
    format_to(std::.back_inserter(b), args...);
}

which probably belongs in include/cantera/base/fmt.h. If you look in that file, you may notice that this isn't the first time that the API for building up a formatted string this way has changed -- we have a workaround to implement format_to using the API that was used before version 5.0.

@speth ... thanks for the comment. There are pro's and con's to both options:

• pro of format_to(std::back_inserter(b), ...) is that it uses fmt directly / con is that it's clunky and doesn't allow fmt::appender
• pro of the template is that it's more flexible (we get to differentiate between fmt versions) / con is that it's no longer a standard fmt function.

I don't have a strong preference here.

OK. I added the template version in a separate commit (i.e. should be squashed), where I used fmt::appender (introduced in v8.0.0). Also fixed a minor compilation warning that I noticed.

PS: I noticed a couple of minor alignment glitches, which I'll fix when squashing.

@speth / @bryanwweber ... done.