Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1119 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 364 364
Lines 47882 47882
=======================================
Hits 35170 35170
Misses 12712 12712
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
CONTRIBUTING.mdSConstruct(replace-std=c++0xby-std=c++11)add recommendations for whitespace use... created a separate PR (Add recommendations for whitespace use to CONTRIBUTING.md #1121)Checklist
scons build&scons test) and unit tests address code coverageThoughts
/std:c++14after Visual Studio 2015 Update 3 - see here)-std=gnu++11) is still necessary ... probably yes