Replace deprecated yaml.safe_load / simplify paths#1049
Merged
bryanwweber merged 10 commits intoCantera:mainfrom Jun 11, 2021
Merged
Replace deprecated yaml.safe_load / simplify paths#1049bryanwweber merged 10 commits intoCantera:mainfrom
bryanwweber merged 10 commits intoCantera:mainfrom
Conversation
Member
Author
|
Fixed a couple of |
ischoegl
force-pushed
the
fix-safe-load
branch
2 times, most recently
from
ac818e4 to
7f58c26
Compare
ischoegl
changed the title
ischoegl
force-pushed
the
fix-safe-load
branch
3 times, most recently
from
f5a31e9 to
59752c6
Compare
Member
Author
|
Ended up removing references to |
bryanwweber
requested changes
Jun 2, 2021
Member
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Thanks for taking this on @ischoegl, I've been wanting to switch more stuff to pathlib for a while!
Member
Author
|
@bryanwweber ... replacing the remaining path strings created some more churn (as expected), but now everything is consistent. |
Also: * introduce module constant utilities.TEST_DATA_PATH * update tests/__init__.py
bryanwweber
requested changes
Jun 2, 2021
Member
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Just a few minor changes from the updates. Thanks again @ischoegl!
Member
Author
|
@bryanwweber ... I believe everything is addressed. Unless there's anything else, this may be ready for a merge. |
bryanwweber
approved these changes
Jun 11, 2021
Member
Author
|
Thanks @bryanwweber! |
8 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
yaml.safe_loadtest/utilities.pySolutionfromPathsomeunit tests topathlibIf applicable, fill in the issue number this pull request is fixing
Fixes #1048
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage