Skip to content

Build fails with fmt 11.0.1 #1735

@mefuller

Description

@mefuller

Problem description

Cantera v3.0.0 fails to build on Fedora when moving to fmt 11 from fmt 10 (no other changes)

Steps to reproduce

The complete buildlog is here: https://kojipkgs.fedoraproject.org//work/tasks/6033/120566033/build.log

...
src/kinetics/InterfaceRate.cpp: In member function 'void Cantera::StickingCoverage::setContext(const Cantera::Reaction&, const Cantera::Kinetics&)':
src/kinetics/InterfaceRate.cpp:395:42: error: 'join' is not a member of 'fmt'
  395 |                 fmt::format("'{}'", fmt::join(anySpecies, "', '")), rxn.equation());
      |                                          ^~~~
src/kinetics/InterfaceRate.cpp:395:42: note: suggested alternatives:
In file included from /usr/include/boost/algorithm/string.hpp:24,
                 from src/pch/system.h:19:
/usr/include/boost/algorithm/string/join.hpp:46:9: note:   'boost::algorithm::join'
   46 |         join(
      |         ^~~~
/usr/include/boost/algorithm/string/join.hpp:46:9: note:   'boost::algorithm::join'
...

Behavior

Build fails

System information

  • Cantera version: 3.0.0
  • OS: Fedora Linux / Rawhide
  • Python/MATLAB/other software versions:

Additional context
I see that @speth is currently working on some improvements/updates around fmt and C++20, so rather than work up a patch for just this issue, does it make more sense to roll this into that work?

Thanks for all that you do maintaining Cantera

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions