-
-
Notifications
You must be signed in to change notification settings - Fork 409
Open
Labels
testsIssues about tests, running the tests, or test resultsIssues about tests, running the tests, or test results
Description
Problem description
Currently, the C++ samples can (and do) contain use of deprecated methods. While these samples are compiled and run as part of scons test, we do not force deprecation warnings to be errors in these samples, and the output written to stdout and stederr is not included in the test comparisons for most of these tests, which means the warnings printed to the screen go unnoticed
Steps to reproduce
- Run
scons test - Run
./build/samples/cxx/bvp/blasius(may require fiddling withLD_LIBRARY_PATH) - See
DeprecationWarningin the output
Behavior
Step 1 passes with no errors. Step 2 produces output starting with:
DeprecationWarning: OneDim::OneDim(vector<Domain1D*>): To be removed after Cantera 3.0; superseded by OneDim::OneDim(v
ector<shared_ptr<Domain1D>>).
DeprecationWarning: OneDim::addDomain(Domain1D*): To be removed after Cantera 3.0; superseded by OneDim::addDomain(shared_ptr<Domain1D>).
DeprecationWarning: Sim1D::Sim1D(vector<Domain1D*>&): To be removed after Cantera 3.0; superseded by Sim1D::Sim1D(vector<shared_ptr<Domain1D>>&).
..............................................................................
Attempt Newton solution of steady-state problem... failure.
Take 10 timesteps 0.0003844 0.7784
Attempt Newton solution of steady-state problem... success.
Problem solved on [6] point grid(s).
System information
- Cantera version: 3.0.0 (806842d)
- OS: macOS 13.5.1
Additional context
I already have a fix prepared for the specific warnings here that will be included in an upcoming PR, but thought it was helpful to track this gap in our testing separately.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
testsIssues about tests, running the tests, or test resultsIssues about tests, running the tests, or test results