-
-
Notifications
You must be signed in to change notification settings - Fork 409
Closed
Description
Problem description
While the lithium_ion_battery.m example is available in MATLAB, it is missing from Python, meaning that corresponding code portions are not covered by CI, see discussion in #1256 (specifically, the only instances where lithium_ion_battery.cti/yaml are used are the MATLAB example, plus a conversion test that is not designed to probe any meaningful features).
While this isn't a bug specifically, I view it as a critical omission that hopefully will get fixed prior to the release of 2.6. At the minimum, the MATLAB test should be converted to a unit test similar to test_kinetics.py::TestSofcKinetics.
System information
- Cantera version: 2.6.0b2
- OS: any
- Python/MATLAB/other software versions: any
Reactions are currently unavailable