Skip to content

Commit f85d54f

Browse files
ischoeglspeth
authored andcommitted
Minor updates
- Add todo item for deprecation of Arrhenius2 constructor - Add missing override declarations in BlowersMaselRate
1 parent dd11605 commit f85d54f

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

include/cantera/kinetics/Arrhenius.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ class BlowersMaselRate final : public ArrheniusBase, public ReactionRate
364364
*/
365365
BlowersMaselRate(double A, double b, double Ea0, double w);
366366

367-
unique_ptr<MultiRateBase> newMultiRate() const {
367+
unique_ptr<MultiRateBase> newMultiRate() const override {
368368
return unique_ptr<MultiRateBase>(
369369
new MultiRate<BlowersMaselRate, BlowersMaselData>);
370370
}
@@ -377,7 +377,7 @@ class BlowersMaselRate final : public ArrheniusBase, public ReactionRate
377377
}
378378

379379
//! Identifier of reaction rate type
380-
virtual const std::string type() const {
380+
virtual const std::string type() const override {
381381
return "Blowers-Masel";
382382
}
383383

@@ -386,9 +386,10 @@ class BlowersMaselRate final : public ArrheniusBase, public ReactionRate
386386
* @param node AnyMap containing rate information
387387
* @param rate_units Unit definitions specific to rate information
388388
*/
389-
virtual void setParameters(const AnyMap& node, const UnitStack& rate_units);
389+
virtual void setParameters(
390+
const AnyMap& node, const UnitStack& rate_units) override;
390391

391-
virtual void getParameters(AnyMap& node) const;
392+
virtual void getParameters(AnyMap& node) const override;
392393

393394
void check(const std::string& equation, const AnyMap& node) override {
394395
checkRate(equation, node);

include/cantera/kinetics/RxnRates.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ class Arrhenius2 : public ArrheniusBase
4848
/// order and the dimensionality (surface or bulk).
4949
/// @param b Temperature exponent. Non-dimensional.
5050
/// @param E Activation energy in temperature units. Kelvin.
51+
///
52+
/// @todo Add deprecation warning pointing out change of activation
53+
/// energy units.
5154
Arrhenius2(doublereal A, doublereal b, doublereal E);
5255

5356
//! Constructor based on AnyMap content

0 commit comments

Comments
 (0)