[Thermo] Deprecate class SemiconductorPhase

speth · speth · commit 111b4909c953 · 2016-04-16T21:06:49.000-04:00
Can't be constructed from ThermoFactory, and constructor from file is not implemented. Also, the getChemPotentials method uses the m_work array, which is never initialized because the private method initLengths() is never called. See #267
diff --git a/include/cantera/thermo/SemiconductorPhase.h b/include/cantera/thermo/SemiconductorPhase.h
@@ -21,12 +21,16 @@ const int cHole = 1;
  * @ingroup thermoprops
  *
  * Class SemiconductorPhase represents electrons and holes in a semiconductor.
+ * @deprecated Broken and unused. To be removed after Cantera 2.3.
  *
  */
 class SemiconductorPhase : public ThermoPhase
 {
 public:
-    SemiconductorPhase() {}
+    SemiconductorPhase() {
+        warn_deprecated("class SemiconductorPhase",
+                        "To be removed after Cantera 2.3.");
+    }
     SemiconductorPhase(std::string infile, std::string id="");
 
     SemiconductorPhase(const SemiconductorPhase& right) {
diff --git a/src/thermo/SemiconductorPhase.cpp b/src/thermo/SemiconductorPhase.cpp
@@ -11,7 +11,10 @@ static doublereal JoyceDixon(doublereal r)
 }
 
 SemiconductorPhase::SemiconductorPhase(std::string infile,
-                                       std::string id_) {}
+                                       std::string id_) {
+    warn_deprecated("class SemiconductorPhase",
+                    "To be removed after Cantera 2.3.");
+}
 
 void SemiconductorPhase::getChemPotentials(doublereal* mu) const
 {

Original file line number	Diff line number	Diff line change
`@@ -21,12 +21,16 @@ const int cHole = 1;`
`21`	`21`	`* @ingroup thermoprops`
`22`	`22`	`*`
`23`	`23`	`* Class SemiconductorPhase represents electrons and holes in a semiconductor.`
	`24`	`+ * @deprecated Broken and unused. To be removed after Cantera 2.3.`
`24`	`25`	`*`
`25`	`26`	`*/`
`26`	`27`	`class SemiconductorPhase : public ThermoPhase`
`27`	`28`	`{`
`28`	`29`	`public:`
`29`		`- SemiconductorPhase() {}`
	`30`	`+ SemiconductorPhase() {`
	`31`	`+ warn_deprecated("class SemiconductorPhase",`
	`32`	`+ "To be removed after Cantera 2.3.");`
	`33`	`+ }`
`30`	`34`	`SemiconductorPhase(std::string infile, std::string id="");`
`31`	`35`
`32`	`36`	`SemiconductorPhase(const SemiconductorPhase& right) {`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,10 @@ static doublereal JoyceDixon(doublereal r)`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`SemiconductorPhase::SemiconductorPhase(std::string infile,`
`14`		`- std::string id_) {}`
	`14`	`+ std::string id_) {`
	`15`	`+ warn_deprecated("class SemiconductorPhase",`
	`16`	`+ "To be removed after Cantera 2.3.");`
	`17`	`+}`
`15`	`18`
`16`	`19`	`void SemiconductorPhase::getChemPotentials(doublereal* mu) const`
`17`	`20`	`{`