Merged
Conversation
cyyeh
changed the title
paopa
approved these changes
Jun 20, 2024
Contributor
paopa
left a comment
paopa
left a comment
There was a problem hiding this comment.
overall LGTM. only a minor comment. 👍
Comment on lines
+200
to
+204
| column["properties"]["alias"] = column["properties"].get( | ||
| "displayName", "" | ||
| ) | ||
| if "displayName" in column["properties"]: | ||
| del column["properties"]["displayName"] |
Contributor
There was a problem hiding this comment.
How about using the pop method to make the code cleaner and more concise?
d = {"c": 2}
d["b"] = d.pop("a", 0)
d["d"] = d.pop("c", 0)
print(d) # {'b': 0, 'd': 2}
paopa
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM_PROVIDERandDOCUMNET_STORE_PROVIDERto env file and docker-compose.yaml in the docker folderazureopenaitoazure_openai, same as the file name for consistency