wren-ui/src/apollo/server/resolvers/sqlPairResolver.ts (1)

114-114: PostgreSQL dialect hint looks correct; consider a typed helper to avoid repeated casting.

You always cast back to WrenSQL after formatting. Consider introducing a small wrapper that returns WrenSQL to reduce casts and standardize dialect options.

Example helper (outside this file, e.g., in @server/utils/sqlFormat.ts):

export function formatWrenSQL(sql: WrenSQL): WrenSQL {
  return safeFormatSQL(sql as string, { language: 'postgresql' }) as WrenSQL;
}

Then here:

-    return safeFormatSQL(wrenSQL, { language: 'postgresql' }) as WrenSQL;
+    return formatWrenSQL(wrenSQL);

wren-ui/src/apollo/server/services/askingService.ts (1)

978-978: Consider passing dialect based on project type for better formatting fidelity.

You have project in scope here. Aligning the dialect with the data source (e.g., tsql for MSSQL, bigquery for BigQuery, etc.) will improve formatting consistency across engines. Today, this call uses the default dialect and only falls back to trino.

Apply this diff locally within the selected line to pass a dialect:

-    const sql = safeFormatSQL(constructCteSql(steps, stepIndex));
+    const sql = safeFormatSQL(constructCteSql(steps, stepIndex), {
+      language: project.type === DataSourceName.MSSQL ? 'tsql' : undefined,
+    });

And add the missing import (outside this hunk):

import { DataSourceName } from '@server/models/adaptor';

If you’d like, I can propose a small mapping helper to cover more engines (bigquery, mysql, trino, etc.) and reuse it in resolvers/services.

wren-ui/src/apollo/server/utils/sqlFormat.ts (1)

1-22: Harden catch-typing, unify logger import, and consolidate SQL formatting

Two small tweaks in src/apollo/server/utils/sqlFormat.ts:

• Annotate catch variables as any and fall back safely:

  } catch (err: any) {
    …
  } catch (_fallbackError: any) {
    logger.error(`Failed to format SQL: ${err?.message ?? String(err)}`);
    return sql;
  }

• Change
  import { getLogger } from './logger';
  to
  import { getLogger } from '@server/utils';

I also found a stray direct import of format from sql-formatter in:

• src/pages/knowledge/question-sql-pairs.tsx:4

Please replace it with our utility:

-import { format } from 'sql-formatter';
+import { safeFormatSQL } from '@server/utils/sqlFormat';  // or from '@server/utils' if re-exported

…
- sqlPairDrawer.openDrawer({ …, sql: format(data.sql) });
+ sqlPairDrawer.openDrawer({ …, sql: safeFormatSQL(data.sql) });

wren-ui/src/apollo/server/resolvers/askingResolver.ts (1)

715-718: Formatting constructed CTE SQL centrally is good; consider dialect in future.

Given project context isn’t passed into nested resolvers, this is fine. If you later decide to tune formatting by datasource, we could fetch the project in this resolver and pass a dialect — but that adds a DB call here. I’d keep it as-is unless you see real formatting issues per engine.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.